Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make node v16 as required #18487

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mkniewallner
Copy link
Contributor

@mkniewallner mkniewallner commented Oct 23, 2022

Changes

Update the CI job name for tests so that node version is only displayed for node 14.

Warning: Since right now only the node 14 job is set as a required check, this means that with this change, the required check will now be the node 16 one, and node 14 tests won't be required anymore, although this is probably desirable.

Context

node 14 has been deprecated in #16969, which is now released in v33, so reversing the logic for tests job so that node version is displayed only for node 14 should make more sense.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mkniewallner mkniewallner marked this pull request as ready for review October 23, 2022 17:21
@rarkins rarkins requested a review from viceice October 23, 2022 17:23
@viceice viceice changed the title ci: only display node version for node 14 ci: make node v16 as required Oct 24, 2022
@viceice viceice enabled auto-merge (squash) October 24, 2022 08:35
@viceice viceice merged commit 867c47f into renovatebot:main Oct 24, 2022
@mkniewallner mkniewallner deleted the ci/version-less-name-node-16 branch October 24, 2022 10:06
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 33.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants