Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/codecommit): add token support in config_js and update docs #18496

Merged
merged 4 commits into from Oct 24, 2022

Conversation

PhilipAbed
Copy link
Collaborator

Changes

Added the option to put AWS_SESSION_TOKEN into the token param in config.js
and patched the index.mx for codecommit

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong PR title otherwise LGTM

@PhilipAbed PhilipAbed changed the title Patchdocs fix: codecommit add token support in config_js and Patchdocs Oct 24, 2022
@PhilipAbed PhilipAbed changed the title fix: codecommit add token support in config_js and Patchdocs feat: codecommit add token support in config_js and Patchdocs Oct 24, 2022
@PhilipAbed
Copy link
Collaborator Author

@viceice can you please merge this? rhys is sick today, the logic has been approved by him, the docs fix too we have problem in numbering in docs which is important

@viceice viceice changed the title feat: codecommit add token support in config_js and Patchdocs feat(platform/codecommit): add token support in config_js and Patchdocs Oct 24, 2022
@viceice viceice changed the title feat(platform/codecommit): add token support in config_js and Patchdocs feat(platform/codecommit): add token support in config_js and update docs Oct 24, 2022
@viceice viceice enabled auto-merge (squash) October 24, 2022 07:40
@viceice
Copy link
Member

viceice commented Oct 24, 2022

@viceice can you please merge this? rhys is sick today, the logic has been approved by him, the docs fix too we have problem in numbering in docs which is important

I know, i already approved and enabled automerge now 😉 Couldn't do that before because of the non semantic PR title before 🙃

@viceice viceice merged commit 4c528e1 into renovatebot:main Oct 24, 2022
@PhilipAbed
Copy link
Collaborator Author

@viceice thank you

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 33.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants