Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit autoupdate --freeze equivalent flag #18752

Closed
l0b0 opened this issue Nov 4, 2022 · 11 comments
Closed

pre-commit autoupdate --freeze equivalent flag #18752

l0b0 opened this issue Nov 4, 2022 · 11 comments
Assignees
Labels
auto:reproduction A minimal reproduction is necessary to proceed manager:pre-commit priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@l0b0
Copy link
Contributor

l0b0 commented Nov 4, 2022

What would you like Renovate to be able to do?

pre-commit autoupdate --freeze creates rev: e0f74cfd5f9497d3279995efeb13d11bd6434b5e # frozen: 0.18.4 type entries in .pre-commit-config.yaml. This guarantees reproducibility in case the tag in the upstream repository is moved for any reason.

Should only require a pinDigests flag in the defaultConfig.

If you have any ideas on how this should be implemented, please tell us here.

I'm not very familiar with TypeScript, but I might give this a try.

Is this a feature you are interested in implementing yourself?

Maybe

@l0b0 l0b0 added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Nov 4, 2022
@rarkins rarkins added auto:reproduction A minimal reproduction is necessary to proceed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@rarkins
Copy link
Collaborator

rarkins commented Nov 4, 2022

This sounds similar conceptually to similar functionality in the github-actions manager

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 6, 2022

@rarkins I don't get the reproduction:needed label on this - it's a feature request, not a bug. Is it just a way to close it in two weeks automatically?

@rarkins
Copy link
Collaborator

rarkins commented Nov 8, 2022

Feature requests are not closed automatically due to lack of reproduction.

But reproductions typically are still required for feature requests, because it's a bad idea to add features without testing them on a real repo first. Sometimes features can be added with just unit tests, but this is not that type of feature.

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 9, 2022

But reproductions typically are still required for feature requests, because it's a bad idea to add features without testing them on a real repo first.

Do you mean I need to implement the feature in order to keep this feature request open? If not, could you please explain in more detail?

@rarkins
Copy link
Collaborator

rarkins commented Nov 9, 2022

I think you misunderstand the meaning of "reproduction". It doesn't mean implementation

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 9, 2022

What does it mean, then? I don't think I've ever heard of anyone using "reproduction" is the context of a feature request.

@rarkins
Copy link
Collaborator

rarkins commented Nov 10, 2022

Please read in full the doc we linked to earlier: https://github.com/renovatebot/renovate/blob/main/docs/development/minimal-reproductions.md

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 10, 2022

This seems to be the only relevant line from the documentation:

A minimal reproduction helps the developers see where the bug or missing feature is, and allows us to verify that the new code meets the requirements.

So I guess a reproduction here means pointing out that the relevant code is in lib/modules/manager/pre-commit. Do you need me to be more specific? Is there anything else needed for a "reproduction" of a missing feature? A test?

@rarkins
Copy link
Collaborator

rarkins commented Nov 10, 2022

It means you create a repository with the minimum content necessary to demonstrate the problem

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 10, 2022

I guess we can't get past this communications barrier, so I'd rather just leave it here.

@l0b0 l0b0 closed this as completed Nov 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:reproduction A minimal reproduction is necessary to proceed manager:pre-commit priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants