Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maven): Skip lookup for parent packages #18788

Merged
merged 14 commits into from
Nov 10, 2022

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 6, 2022

Changes

When package described in pom.xml has been referenced as top-level parent, skip lookups for every dependency referencing it.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Nov 7, 2022

Would there ever be a reason why someone would want to upgrade a parent Pom? If so then we should think to make it possible to override using package rules

@zharinov
Copy link
Collaborator Author

zharinov commented Nov 8, 2022

Probably what we can do is to mark these depTypes as root-parent and create default host rule preset that ignores it?

@rarkins
Copy link
Collaborator

rarkins commented Nov 8, 2022

Yes, I think it means we need to set enabled=false rather than skipReason, because skipReason isn't currently possible to override

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@rarkins Should be marked as feat instead of fix?

lib/workers/repository/errors-warnings.ts Outdated Show resolved Hide resolved
@rarkins rarkins changed the title fix(maven): Skip lookup for parent packages feat(maven): Skip lookup for parent packages Nov 10, 2022
@rarkins rarkins enabled auto-merge (squash) November 10, 2022 15:08
@rarkins rarkins merged commit 5162394 into renovatebot:main Nov 10, 2022
@rarkins rarkins deleted the fix/skip-maven-repo-parent branch November 10, 2022 15:25
@pmwmedia
Copy link

Thank you, guys! I cannot await to test it in my project :)

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Lookup Warnings for Internal Maven Artifacts
5 participants