-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maven): Skip lookup for parent packages #18788
feat(maven): Skip lookup for parent packages #18788
Conversation
Would there ever be a reason why someone would want to upgrade a parent Pom? If so then we should think to make it possible to override using package rules |
Probably what we can do is to mark these |
Yes, I think it means we need to set enabled=false rather than skipReason, because skipReason isn't currently possible to override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
@rarkins Should be marked as feat instead of fix?
Thank you, guys! I cannot await to test it in my project :) |
🎉 This PR is included in version 34.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
When package described in
pom.xml
has been referenced as top-level parent, skip lookups for every dependency referencing it.Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: