New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager/terraform): remove default versioning #19161

Merged

rarkins merged 1 commit into main from fix/terraform/default-versioning

Nov 29, 2022

Member

viceice commented Nov 29, 2022 •

edited

Changes

remove default hashicorp versioning from terraform manager.
add docker datasource to supportedDatasources

Context

fixes Terraform manager doesn't properly use existing container tag on Kubernetes resource #19151

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository


          fix(manager/terraform): remove default versioning

c031c1e

viceice requested a review from rarkins

November 29, 2022 07:20

Member Author

viceice commented Nov 29, 2022

tested here: https://github.com/renovate-reproductions/renovate-terraform-bug-19151

Member Author

viceice commented Nov 29, 2022

no newer version on docker hub¹ yet

https://hub.docker.com/r/timberio/vector/tags?page=1&name=0.25. ↩

Member Author

viceice commented Nov 29, 2022

@rarkins can have small side effects to git based deps, as they now use the datasource default versioning instead of hashicorp

rarkins approved these changes

View reviewed changes

rarkins merged commit d2cf863 into main

rarkins deleted the fix/terraform/default-versioning branch

November 29, 2022 07:44

Collaborator

renovate-release commented Nov 29, 2022

🎉 This PR is included in version 34.41.1 🎉

The release is available on:

GitHub release
34.41.1

Your semantic-release bot 📦🚀

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.