New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): set by default Accept header for json requests #19202
feat(http): set by default Accept header for json requests #19202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that already set by got? i thought responseType=json
should do that. 🤔
Seems like it actually should... 🤔 Got on this trail because I have got some 406 errors on |
no, you're on wrong version. We're still using v11. this was the only line were the accept is set 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Should maybe have a test-case 😏
🎉 This PR is included in version 34.47.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Adds by default an
Accept
header to http calls originating fromgetJson
.Context
Came across this while debugging #19173 and the backend seems to require this.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: