feat: add osgi dependency manager #19282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rombert
changed the title
secustor
requested changes
Dec 6, 2022
lib/modules/manager/osgifeature/__fixtures__/bundles-as-strings.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
HonkingGoose
suggested changes
Dec 7, 2022
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
reviewed
Dec 7, 2022
secustor
requested changes
Dec 7, 2022
lib/modules/manager/osgifeature/__fixtures__/double-slash-not-comment.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
|
@rarkins - |
rarkins
requested changes
Dec 16, 2022
Co-authored-by: Rhys Arkins <rhys@arkins.net>
rombert
requested review from
rarkins
and removed request for
viceice and
secustor
rarkins
previously approved these changes
Dec 16, 2022
secustor
requested changes
Dec 16, 2022
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
secustor
approved these changes
Dec 17, 2022
rarkins
approved these changes
Dec 17, 2022
|
@rarkins - is there anything left for me to do here? I see two approvals, not sure if I should request other reviews. |
|
It needs to be updated to be up to date with main branch |
Wasn't aware, thanks. Updated. |
|
🎉 This PR is included in version 34.65.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new dependency manager -
osgi.Context
Closes #18861
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: