feat(presets): group @vaadin/ packages together. #19365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Dec 12, 2022
viceice
requested changes
Dec 13, 2022
viceice
approved these changes
Dec 15, 2022
|
🎉 This PR is included in version 34.57.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR added the ability to group all the
@vaadin/javascript packages togerther in one PR. I named the groupvaadinJavascript, becausevaadinis a full stack java framework and there also the java part there are not posing problem for now.Context
I add a project using
vaadinto our renovate config at work, and it opens ~80 PR to update all the JavaScript packages to the same version, so I tough I'd add a group to reduce this to one atomic PR for the update.Documentation (please check one with an [x])
The other PR of this kind I checked didn't update the documentation, so I assume it's the same here, but if there's some modification to do, I'll add them.
How I've tested my work (please select one)
I have verified these changes via:
I don't have seen examples of tests for groups in the repo, but if there's some, I'd be glad to implement some for the group definition this PR added.