Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache): reset semanticCommits after clone #19457

Merged
merged 3 commits into from Dec 17, 2022
Merged

fix(cache): reset semanticCommits after clone #19457

merged 3 commits into from Dec 17, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 16, 2022

Changes

  • Defers semantic commit detection until after dependency extraction
  • Deletes cached semanticCommits value after any clone
  • Extends message count from 10 to 20, to reduce chance of flapping

Context

Fixes #19260

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice December 16, 2022 18:39
@rarkins rarkins enabled auto-merge (squash) December 17, 2022 06:05
@rarkins rarkins merged commit ef7f520 into main Dec 17, 2022
@rarkins rarkins deleted the fix/19260-semantic-commits-cache branch December 17, 2022 06:24
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.60.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cache.semanticCommits can never be reset/recalculated
3 participants
@rarkins @renovate-release @viceice