Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(composer): stash/unstash before install #19518

Merged
merged 1 commit into from
Dec 21, 2022
Merged

feat(composer): stash/unstash before install #19518

merged 1 commit into from
Dec 21, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 21, 2022 •
edited by viceice

Changes

Stashes/unstashes before running composer install

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice December 21, 2022 14:36
@rarkins rarkins enabled auto-merge (squash) December 21, 2022 15:02
viceice
viceice reviewed Dec 21, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tested it with composer.json inside a sub directory?

otherwise LGTM

viceice
viceice approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@rarkins rarkins merged commit 52d773b into main Dec 21, 2022
@rarkins rarkins deleted the feat/composer-stash-install branch December 21, 2022 16:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.70.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose mentioned this pull request Dec 23, 2022
Closed
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarkins @renovate-release @viceice