Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version constraint to sidecar / containerbase #19544

Open
viceice opened this issue Dec 23, 2022 · 1 comment
Open

Add version constraint to sidecar / containerbase #19544

viceice opened this issue Dec 23, 2022 · 1 comment
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented Dec 23, 2022

What would you like Renovate to be able to do?

We like to constraint our sidecar image, so we can make breaking changes in future and older renovate doen't fail.

If you have any ideas on how this should be implemented, please tell us here.

yes:

  1. centralize sidecar image refenrences to single place
  2. add constrains

I'll do this in two PR's as the contraints need a lot test changes. So I'll centralize image usage first

Is this a feature you are interested in implementing yourself?

Yes

@viceice viceice added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation labels Dec 23, 2022
@viceice viceice self-assigned this Dec 23, 2022
@viceice viceice added this to Ready in Containerbase via automation Dec 23, 2022
@viceice viceice moved this from Ready to In Progress in Containerbase Dec 23, 2022
@viceice
Copy link
Member Author

viceice commented Dec 23, 2022

Additionally we should use /usr/local/buildpack/version to get the containerbase version and validate the version.
So we can ensure a required minimum version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
Containerbase
  
In Progress
Development

No branches or pull requests

1 participant