Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gradle): enable property accessors for registry URLs #19609

Merged
merged 1 commit into from Dec 29, 2022

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Dec 29, 2022

Changes

  • Extends the existing support for property accesors to registry URLs
    • name and url of maven repo declarations may be specified as properties (example)
  • Ignores as String type casts, occasionally used with properties in Kotlin projects (example)
  • Refactoring: Extracts a common URI pattern to reuse across all spots where java.net.URI is expected
    • Idea: For better maintainability, have a common selector for URLs specified directly (ref) or via uri (ref).

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice merged commit 80d53a1 into renovatebot:main Dec 29, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.76.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants