Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Azure DevOps Marketplace tasks #19694

Closed
5 tasks done
jessehouwing opened this issue Jan 5, 2023 · 18 comments · Fixed by #19692
Closed
5 tasks done

Add support for the Azure DevOps Marketplace tasks #19694

jessehouwing opened this issue Jan 5, 2023 · 18 comments · Fixed by #19692
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@jessehouwing
Copy link
Contributor

jessehouwing commented Jan 5, 2023

What would you like Renovate to be able to do?

Currently Renovate only updates the built-in tasks supplied by Microsoft and ignores any task that's installed through the Azure DevOps Marketplace.

Renovate should also suggest updates for any public marketplace installed tasks.

If you have any ideas on how this should be implemented, please tell us here.

Is this a feature you are interested in implementing yourself?

Yes

@JamieMagee To transfer the repo to generate the static file I can initiate a repository transfer:

@jessehouwing jessehouwing added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Jan 5, 2023
@jessehouwing
Copy link
Contributor Author

@geekzter FYI

@JamieMagee JamieMagee added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Jan 8, 2023
@JamieMagee
Copy link
Contributor

We can use this issue to track migrating the repo. This is fine.

@JamieMagee
Copy link
Contributor

@jessehouwing it looks like the order might not be consistent. See #19720

@jessehouwing
Copy link
Contributor Author

@JamieMagee I had already updated the script to keep order. But the json file in the initial pull-request is from before that update, so we'll have to do at least one big diff commit to fix that in the renovate repo.

I'm seeing one more interesting thing happen in the update from today, and that's from 2 extension that have the same display name (current sort order) (and one should never have been a public extension to begin with it seems) which seem to flip-flop in the data file sigh.

I can see if I can simply order the file alphabetically upon save.

@jessehouwing
Copy link
Contributor Author

jessehouwing commented Jan 8, 2023

Updated the scripts to sort the json properties alphabetically before save. So it should now be in consistent order.

renovatebot/azure-devops-marketplace@f32bf41

@jessehouwing
Copy link
Contributor Author

jessehouwing commented Jan 8, 2023

Some things I'd love to (see) add(ed), but would be more work:

  • Add support for the preview flag (task.json)
  • Add support for the deprecated flag (task.json)
  • Add support for the repository attribute (extension.json)
  • Add support for marking a whole extension deprecated (no longer returned by the marketplace API)
  • Suggest renames (same task.id, higher task.version, different task.name).

These require a change in the datasource structure and I'd need to better understand how renovatebot does that.

@jessehouwing
Copy link
Contributor Author

jessehouwing commented Jan 8, 2023

@jessehouwing
Copy link
Contributor Author

jessehouwing commented Jan 9, 2023

@jessehouwing
Copy link
Contributor Author

@JamieMagee
Copy link
Contributor

@JamieMagee To transfer the repo to generate the static file I can initiate a repository transfer:

I received your invitation, but I don't have the necessary permissions in the renovatebot org. You'll need to invite @rarkins to do the repo transfer.

@rarkins
Copy link
Collaborator

rarkins commented Jan 10, 2023

Because it's a personal repo, I think you'll actually need to transfer it to me (@rarkins) before I can then transfer it into the renovatebot org

@HonkingGoose
Copy link
Collaborator

That's correct, see this quote from the GitHub Docs: 1

Repository transfers and organizations

To transfer repositories to an organization, you must have repository creation permissions in the receiving organization. If organization owners have disabled repository creation by organization members, only organization owners can transfer repositories out of or into the organization.

Once a repository is transferred to an organization, the organization's default repository permission settings and default membership privileges will apply to the transferred repository.

Footnotes

  1. https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository#repository-transfers-and-organizations

@jessehouwing
Copy link
Contributor Author

@JamieMagee @rarkins can you overwrite the AZURE DEVOPS PAT secret with a fresh PAT (expires yearly) with 'Marketplace (read)' permissions on the 'all accessible organisations' scope?

@JamieMagee
Copy link
Contributor

@rarkins I don't have permissions. You'll need to do it.

@rarkins
Copy link
Collaborator

rarkins commented Jan 16, 2023

I've updated it with my own PAT now. What's the best way to make sure it's working?

@jessehouwing
Copy link
Contributor Author

Running the workflow manually. I just triggered a run.

@jessehouwing
Copy link
Contributor Author

PAT is working. I increased the logging a little bit to be sure :).

A new run is both fetching new extensions and downloading the vsix files.

@rarkins To what should I change the committer? Right now it's still making all commits (including bot) under my name. Should it be Renovate(bot)? Or is it ok to leave it under my creds for now?

@rarkins
Copy link
Collaborator

rarkins commented Jan 16, 2023

I'm not sure it makes any difference? If not then fine to leave as is until it's necessary to change

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants