Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-demand config migration PRs using Dashboard #19783

Open
Tracked by #16359
rarkins opened this issue Jan 11, 2023 · 6 comments
Open
Tracked by #16359

On-demand config migration PRs using Dashboard #19783

rarkins opened this issue Jan 11, 2023 · 6 comments
Labels
core:dashboard Related to Dependency Dashboard functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 11, 2023

What would you like Renovate to be able to do?

Add a checkbox to the dependency dashboard which allows users to open a migration PR on demand

If you have any ideas on how this should be implemented, please tell us here.

Remove the log warning display in dashboard (so that this information is not duplicated).

Display the message prominently that config migration is required (maybe with a learn more link).

Have a checkbox allowing users to open the config migration PR.

Not sure what to do if they uncheck the checkbox after the PR is created though. Maybe keep it? They can close it manually if they really want.

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready core:dashboard Related to Dependency Dashboard functionality labels Jan 11, 2023
@HonkingGoose
Copy link
Collaborator

Not sure what to do if they uncheck the checkbox after the PR is created though. Maybe keep it? They can close it manually if they really want.

I think we can keep the default behavior:

  1. Select PR via Dependency Dashboard
  2. Don't want the PR anymore: close it yourself

If you want to do the "close PR if checkbox is unchecked" thing, there's a possible edgecase:
Renovate de-selects the checkboxes after it finishes the requested run on the repository. So wouldn't Renovate then close the config migration PR on the next run?

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 12, 2023

Actually, if we detect that the PR is open we should remove the message and the checkbox from the dashboard (or perhaps replace it with a message/link to the PR)

@HonkingGoose
Copy link
Collaborator

I vote "replace it with a message/link to the PR" then.

The Dependency Dashboard should always show all pending stuff, removing the message and checkbox goes against that idea.

@HonkingGoose
Copy link
Collaborator

Actually, if we detect that the PR is open we should remove the message and the checkbox from the dashboard (or perhaps replace it with a message/link to the PR)

How about moving the checkbox item to different sections on the Dependency Dashboard? Like this:

  1. Renovate detects config migration is needed,
  2. Renovate creates a new checkbox for the config migration on the Dependency Dashboard in the Pending approval section,
  3. User clicks the config migration checkbox,
  4. Renovate creates the PR,
  5. Once PR is open: Renovate moves the checkbox to the Open section.

What happens next depends on the user:

  • User merges config PR: Renovate drops the checkbox from the Dependency Dashboard -> done.
  • User closes config PR: Renovate moves the checkbox to the Ignored or Blocked section -> done.

If user wants new config migration PR, after ignoring one: user renames old PR to something else, and Renovate creates a new PR.

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 18, 2023

I think that a migration PR is much more important than regular ones so should be in its own section (at the top) instead of combined with other Pending PRs where it could be missed

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Apr 18, 2023

You're right, let's put the config migration in its own section at the top.

@HonkingGoose HonkingGoose mentioned this issue Aug 19, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:dashboard Related to Dependency Dashboard functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants