Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(manager/terraform): remove usages of any and use types #19815

Merged
merged 6 commits into from Jan 23, 2023

Conversation

secustor
Copy link
Collaborator

Changes

  • rename GenericDockerImageRef to GenericDockerImageRefExtractor
  • remove any usages of any
  • use type defintion for parsed HCL files
  • small code style improvements

Context

#19269 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more later

@secustor secustor requested a review from viceice January 16, 2023 10:28
# Conflicts:
#	lib/modules/manager/terraform/extract.spec.ts
#	lib/modules/manager/terraform/extractors/resources/helm-release.ts
@viceice viceice enabled auto-merge (squash) January 23, 2023 09:21
@viceice viceice merged commit 72bd0d3 into renovatebot:main Jan 23, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.110.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@secustor secustor deleted the use_types_for_terraform_manager branch January 23, 2023 10:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants