feat(manager/helmfile): Lock file support #19865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaik
force-pushed
the
feat/helmfile-deps
branch
from
995fc8b
to
a32fe62
Compare
viceice
requested changes
Jan 16, 2023
Rename chartFile to helmfileFile Replace Chart.yaml leftover with helmfile.lock
secustor
requested changes
Jan 17, 2023
secustor
requested changes
Jan 18, 2023
viceice
reviewed
Jan 23, 2023
viceice
reviewed
Jan 23, 2023
|
@viceice Worked my way through your comments. Let me know if I did something weird or misunderstood anything |
|
Updated PR again @viceice Let me know if anything else looks weird |
secustor
requested changes
Jan 30, 2023
secustor
previously approved these changes
Jan 30, 2023
viceice
reviewed
Jan 30, 2023
Leftovers from the helmv3 code its based on
secustor
approved these changes
Feb 2, 2023
viceice
approved these changes
Feb 4, 2023
viceice
changed the title
|
🎉 This PR is included in version 34.123.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR attempts to add support for helmfile lock files. This PR is based on the existing work with helm chart lock files.
There is a corresponding PR to add the helmfile tool to the
renovate/renovatedocker image renovatebot/docker-renovate-full#1276Context
We use renovate to keep our helmfile chart versions updated, so this is to avoid the toil of manually running
helmfile deps.Resolves #7719
Did an initial test run of this here: nikolaik/renovate-helmfile.lock#2
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: