fix(platform): fix types and docs #19944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
commented
Jan 20, 2023
viceice
commented
Jan 20, 2023
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
suggested changes
Jan 20, 2023
| GitLab and Gitea implement draft status by checking if the PR's title starts with certain strings. | ||
| This means that `draftPR` on GitLab and Gitea are incompatible with the legacy method of triggering Renovate to rebase a PR by renaming the PR to start with `rebase!`. | ||
| Gitea and GitLab implement draft status by checking if the PR's title starts with certain strings. | ||
| This means that `draftPR` on Gitea and GitLab are incompatible with the legacy method of triggering Renovate to rebase a PR by renaming the PR to start with `rebase!`. |
There was a problem hiding this comment.
Sentence too long
This sentence is too long and tries to explain too much at once. The key points seem to be:
- Because Gitea and GitLab have a different method of checking if a PR is draft, the
draftPRfeature doesn't work as expected. - You can't use the legacy method of triggering Renovate by prefixing the PR with the text
rebase!.
Why are we mentioning a "legacy method"
If the method is "legacy" why do we mention it? People can use the Dependency Dashboard to request a rebase, but maybe that doesn't work on the affected platforms?
Maybe we can streamline the sentence by dropping the reference to the legacy method?
There was a problem hiding this comment.
make a suggestion, otherwise i would like to shift this to a seperate pr. Intension was to order platforms
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
rarkins
previously approved these changes
Jan 24, 2023
viceice
commented
Jan 24, 2023
rarkins
approved these changes
Jan 24, 2023
|
🎉 This PR is included in version 34.112.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PlatformIdusageContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: