Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gradle): replace individual value matchers with placeholder #19996

Merged
merged 3 commits into from Feb 3, 2023

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Jan 23, 2023

Changes

  • Replace all occurrences of qConcatExpr(qTemplateString, qPropertyAccessIdentifier, qVariableAccessIdentifier) with a qValueMatcher expression. The purpose is to eliminate code redundancies and to abstract away different value types from matching patterns.

  • extract.ts: Don't override the Maven datasource, registry URLs and depType for deps from other ecosystems. E.g., assuming a Jib container image, a node version or npm dependencies are extracted from Gradle files, then Maven-specific dep attributes shouldn't be set.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title refactor(manager/gradle): replace individual value matchers with placeholder feat(manager/gradle): replace individual value matchers with placeholder Jan 24, 2023
@viceice viceice requested a review from zharinov January 24, 2023 05:26
@viceice
Copy link
Member

viceice commented Jan 24, 2023

marked as feature because of behavior change

zharinov
zharinov previously approved these changes Jan 24, 2023
lib/modules/manager/gradle/extract.ts Outdated Show resolved Hide resolved
@Churro
Copy link
Collaborator Author

Churro commented Feb 3, 2023

Could this be merged, please?

@rarkins rarkins enabled auto-merge (squash) February 3, 2023 18:33
@rarkins rarkins merged commit bfc38bf into renovatebot:main Feb 3, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.122.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants