Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/asdf): remove default versionings and packageNames #20196

Merged
merged 3 commits into from Feb 3, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 3, 2023

Changes

Remove default semver versioning and packageName if it equals to depName.

semver is the default versioning, so we don't need to define it explicit.
Renovate uses depName as packageName, so we don't need to manually define it.

Makes maintenance easier.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins February 3, 2023 19:35
@rarkins rarkins enabled auto-merge (squash) February 3, 2023 19:39
@rarkins rarkins merged commit 49a50e7 into main Feb 3, 2023
@rarkins rarkins deleted the feat/asdf-cleanup branch February 3, 2023 20:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.122.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants