Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use packageName and not depName for datasource lookups #20474

Merged
merged 20 commits into from Feb 21, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 17, 2023

Refactors datasources + lookup to use packageName primarily and not depName.

BREAKING CHANGE: Anyone using renovate as a library and calling getPkgReleases must supply packageName and not depName

RahulGautamSingh and others added 10 commits February 17, 2023 08:16
Changes `rangeStrategy` default value from `'replace'` to `'auto'`.

Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function.

Closes #19800

BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time.

Closes #13732
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
BREAKING CHANGE: Anyone using renovate as a library and calling getPkgReleases must supply packageName and not depName
@rarkins rarkins added the breaking Breaking change, requires major version bump label Feb 17, 2023
@rarkins rarkins requested a review from viceice February 17, 2023 09:07
lib/modules/datasource/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/docker/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/docker/index.ts Outdated Show resolved Hide resolved
rarkins and others added 2 commits February 17, 2023 10:57
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@@ -228,6 +228,12 @@ describe('modules/manager/bazel/parser', () => {
group = "com.example2",
artifact = "bar",
version = "2.2.2",
),
maven.artifact(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a bad merge. 🤔

# Conflicts:
#	lib/modules/datasource/index.spec.ts
#	lib/modules/datasource/pypi/index.spec.ts
#	lib/workers/repository/process/lookup/common.spec.ts
@rarkins rarkins requested a review from viceice February 20, 2023 18:20
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing, otherwise LGTM

lib/modules/manager/swift/extract.ts Outdated Show resolved Hide resolved
@rarkins rarkins merged commit b0f8f6f into v35 Feb 21, 2023
@rarkins rarkins deleted the refactor/datasource-package-name branch February 21, 2023 05:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants