Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: non-null packageName #20485

Merged
merged 3 commits into from Mar 4, 2023
Merged

refactor: non-null packageName #20485

merged 3 commits into from Mar 4, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 17, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice February 17, 2023 15:58
viceice
viceice previously approved these changes Feb 17, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still missing coverage

# Conflicts:
#	lib/modules/manager/types.ts
@rarkins rarkins requested a review from viceice March 4, 2023 06:26
@rarkins rarkins disabled auto-merge March 4, 2023 06:28
@rarkins rarkins merged commit f2d162e into main Mar 4, 2023
@rarkins rarkins deleted the refactor/package-name-non-null branch March 4, 2023 06:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.155.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants