Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gradle): add support for map notation deps in Groovy maps #20798

Merged
merged 1 commit into from Mar 8, 2023

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Mar 7, 2023

Changes

While working on #20763, I found that map notation dependencies are currently not matched if occurring within Groovy maps. This is because map assignments are parsed prior to dependencies and the Groovy map already causes a match.

In practice, this means the dependency in the following snippet wouldn't be matched at all:

ext {
  aspectj = [group: 'org.aspectj', name: 'aspectjrt', version: '1.6.12']
}

dependencies {
  runtime(aspectj)
}

This PR adds an additional clause to the Groovy map assignment that distinguishes between regular maps and map notation deps within maps.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Mar 8, 2023
Merged via the queue into renovatebot:main with commit 9823180 Mar 8, 2023
9 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.159.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

RahulGautamSingh pushed a commit to RahulGautamSingh/renovate that referenced this pull request Mar 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants