Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: safely parse emoji shortcodes #20814

Merged
merged 2 commits into from Mar 9, 2023

Conversation

JamieMagee
Copy link
Contributor

Changes

Define and use a schema for type checking emoji shortcodes

Context

This is required for #20553.

One of the rules of @total-typescript/ts-reset changes the return type of JSON.parse from any to unknown1. This means that we need to do runtime type checking to verify the data that we are parsing.

There are currently a lot of places where we use JSON.parse and each and every one of those will need to be type checked before #20553 can be considered complete.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Footnotes

  1. https://github.com/total-typescript/ts-reset#make-jsonparse-return-unknown

@viceice viceice added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit 67b076a Mar 9, 2023
9 checks passed
@viceice viceice deleted the refactor/safe-parse-emoji-shortcodes branch March 9, 2023 06:59
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.159.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants