Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composer): skip path repo dependencies #20887

Merged
merged 4 commits into from Mar 14, 2023

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 12, 2023

Changes

Skips composer path repo dependencies in the extraction phase. Previously these were looked up on packagist.org instead which does either not work, is unwanted or might be problematic even for name-clashes.

Context

This is the first step for a path-based datasource as it was described in #11674 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@herndlm
Copy link
Contributor Author

herndlm commented Mar 12, 2023

I guess this could be seen as a fix even? The actual feature is the path-based datasource support I suppose 🤔

@herndlm herndlm changed the title feat(composer): Skip path repo dependencies feat(composer): skip path repo dependencies Mar 12, 2023
@herndlm herndlm marked this pull request as draft March 13, 2023 08:00
@herndlm herndlm marked this pull request as ready for review March 13, 2023 08:07
@herndlm herndlm requested a review from rarkins March 13, 2023 16:45
@rarkins rarkins added this pull request to the merge queue Mar 14, 2023
Merged via the queue into renovatebot:main with commit 3f5a0c0 Mar 14, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@herndlm herndlm deleted the ignore-composer-path-repos branch March 14, 2023 08:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants