Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(adding-package-manager): add missing functions of ManagerAPI interface #21535

Merged

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Apr 16, 2023

Changes

Add missing functions of the ManagerAPI interface to "add package mangager` doc.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor changed the title docs(adding-package-manager): add additional optional functions of Ma… docs(adding-package-manager): add missing functions of ManagerAPI interface Apr 16, 2023
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
@secustor secustor marked this pull request as ready for review April 20, 2023 07:06
viceice
viceice previously approved these changes Apr 20, 2023
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we want to order the headings and table items?

docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add @HonkingGoose suggestion

docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
docs/development/adding-a-package-manager.md Outdated Show resolved Hide resolved
secustor and others added 3 commits April 28, 2023 09:33
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue Apr 29, 2023
Merged via the queue into renovatebot:main with commit ab04c11 Apr 29, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.65.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@secustor secustor deleted the docs/add_functions_to_add_package_manager_docs branch May 2, 2023 08:01
mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
…erface (renovatebot#21535)

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants