fix: sanitize special characters in URLs #21575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
approved these changes
Apr 18, 2023
|
@viceice can we merge this PR already or is there something left to do / check? |
|
🎉 This PR is included in version 35.53.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The sanitizing of URLs should include special characters like %, (, ), ! (and more)
This PR will include all characters by defining only characters that don't trigger the sanitization (@ because it's the separator between credentials and URL and / because it's the URL separator).
Context
I've noticed the mentioned behavior only on git clone errors.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: