Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package-rules)!: remove fuzzy matchPaths matching #22394

Merged
merged 1 commit into from May 24, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 24, 2023

Changes

Drops support for partial string matching in matchPaths

Context

This feature has been deprecated until now.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

BREAKING CHANGE: packageRules.matchPaths will now do only glob matching and not fuzzy ‘partial string match’.
@rarkins rarkins added the breaking Breaking change, requires major version bump label May 24, 2023
@rarkins rarkins requested a review from viceice May 24, 2023 04:24
@rarkins rarkins enabled auto-merge (squash) May 24, 2023 04:24
@rarkins rarkins merged commit a116d43 into v36 May 24, 2023
9 checks passed
@rarkins rarkins deleted the feat/remove-math-paths-fuzzy branch May 24, 2023 06:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants