Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasource/conan): add sourceUrl when artifactory is used #22656

Merged
merged 15 commits into from Jun 15, 2023
Merged

feat(datasource/conan): add sourceUrl when artifactory is used #22656

merged 15 commits into from Jun 15, 2023

Conversation

MartijnLeijssen-TomTom
Copy link
Contributor

@MartijnLeijssen-TomTom MartijnLeijssen-TomTom commented Jun 9, 2023 •
edited

Changes

When using conan datasource and using artifactory to upload the packages, the sourceUrl is fetched from the conan recipe property conan.package.url which is set on artifactory.

Context

Create a Release Notes chapter in the PR's that are being raised by renovate for Conan packages.
The initial discussion can be found here.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MartijnLeijssen-TomTom MartijnLeijssen-TomTom changed the title Feat/changelog conan feat: add release note support for conan datasource when artifactory is used Jun 9, 2023
@rarkins rarkins changed the title feat: add release note support for conan datasource when artifactory is used feat(datasource/conan): add sourceUrl when artifactory is used Jun 14, 2023
viceice
viceice reviewed Jun 15, 2023
View reviewed changes
lib/modules/datasource/conan/__fixtures__/artifactory.json Outdated Show resolved Hide resolved
lib/modules/datasource/conan/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/datasource/conan/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/conan/index.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Jun 15, 2023
View reviewed changes
@viceice viceice enabled auto-merge June 15, 2023 15:15
@viceice viceice added this pull request to the merge queue Jun 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 15, 2023
@zharinov zharinov requested a review from viceice June 15, 2023 15:49
@viceice viceice added this pull request to the merge queue Jun 15, 2023
Merged via the queue into renovatebot:main with commit f611217 Jun 15, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.119.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mugioka mugioka mentioned this pull request Jun 21, 2023
Merged
6 tasks
@rarkins rarkins mentioned this pull request Jul 14, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MartijnLeijssen-TomTom @renovate-release @viceice @rarkins