Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: separate extractedConstraints from constraints #22823

Merged
merged 6 commits into from Jun 17, 2023
Merged

fix: separate extractedConstraints from constraints #22823

merged 6 commits into from Jun 17, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 16, 2023

Changes

Keeps extractedConstraints separate from constraints during lookup phase so that the two can be distinguished during artifacts stage.

Context

Fixes #22762

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice June 16, 2023 10:58
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 16, 2023

@zharinov is there a user guide for how to easily determine where coverage is missing? For example codecov does not seem help here: https://app.codecov.io/gh/renovatebot/renovate/pull/22823

@rarkins rarkins requested a review from zharinov June 16, 2023 11:10
@zharinov
Copy link
Collaborator

I would like to find the way to upload HTML-based coverage reports somewhere.
They often were more useful than codecov UI.

viceice
viceice previously approved these changes Jun 16, 2023
View reviewed changes
lib/modules/manager/npm/post-update/npm.ts Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Jun 16, 2023

coverage issue again 😕

@viceice
Copy link
Member

viceice commented Jun 16, 2023

@zharinov can we get a simple yarn command to run all shards locally to find those coverage issues?

@zharinov
Copy link
Collaborator

I'm not sure it will help. I think what we need is to (1) reset codecov data, (2) re-run build on main and (3) update branch

@zharinov
Copy link
Collaborator

Most likely, detected coverage changes aren't in this PR's diff, but it must be in the files changed in this PR.

@rarkins rarkins requested a review from viceice June 17, 2023 08:16
@viceice viceice added this pull request to the merge queue Jun 17, 2023
Merged via the queue into main with commit 85ae416 Jun 17, 2023
36 checks passed
@viceice viceice deleted the fix/22762-extracted-constraints branch June 17, 2023 09:39
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.124.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mugioka mugioka mentioned this pull request Jun 21, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@zharinov zharinov Awaiting requested review from zharinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rarkins @zharinov @viceice @renovate-release