Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): optionally remove self-hosted config file once read #22857

Merged
merged 19 commits into from Jun 20, 2023
Merged

feat(config): optionally remove self-hosted config file once read #22857

merged 19 commits into from Jun 20, 2023

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented Jun 18, 2023 •
edited

Changes

Adds an experimental feature that enables users to delete the self-hosted config file once it has been read

Context

#22691

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti Gabriel-Ladzaretti changed the title teat(config): optionally remove self-hosted config file once read feat(config): optionally remove self-hosted config file once read Jun 18, 2023
@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review June 18, 2023 19:37
viceice
viceice reviewed Jun 18, 2023
View reviewed changes
lib/workers/global/config/parse/file.spec.ts Outdated Show resolved Hide resolved
lib/workers/global/config/parse/file.spec.ts Outdated Show resolved Hide resolved
lib/workers/global/config/parse/file.spec.ts Outdated Show resolved Hide resolved
@Gabriel-Ladzaretti @viceice
cr changes
e10ac59 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins @HonkingGoose
Update docs/usage/self-hosted-experimental.md
f774843 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
HonkingGoose approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs.

@rarkins rarkins enabled auto-merge June 19, 2023 14:33
@rarkins rarkins added this pull request to the merge queue Jun 20, 2023
Merged via the queue into renovatebot:main with commit ee9c45a Jun 20, 2023
36 checks passed
@rarkins rarkins deleted the feat/remove-config-file branch June 20, 2023 21:10
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.137.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mugioka mugioka mentioned this pull request Jun 21, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gabriel-Ladzaretti @renovate-release @viceice @rarkins @HonkingGoose