Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use klona library for deep clone #22979

Merged
merged 11 commits into from Jun 26, 2023
Merged

feat: Use klona library for deep clone #22979

merged 11 commits into from Jun 26, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 26, 2023 •
edited

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins June 26, 2023 11:53
@zharinov zharinov requested a review from viceice June 26, 2023 12:01
viceice
viceice reviewed Jun 26, 2023
View reviewed changes
lib/util/clone.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from viceice June 26, 2023 12:38
rarkins
rarkins requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a try/catch and fall back to old approach with a warning if klona throws?

rarkins
rarkins reviewed Jun 26, 2023
View reviewed changes
lib/util/clone.ts Outdated Show resolved Hide resolved
@zharinov zharinov requested a review from rarkins June 26, 2023 15:42
@rarkins rarkins added this pull request to the merge queue Jun 26, 2023
Merged via the queue into renovatebot:main with commit ef6f0c7 Jun 26, 2023
36 checks passed
@rarkins rarkins deleted the feat/switch-to-klona-library branch June 26, 2023 17:31
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.143.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @renovate-release @viceice @rarkins