Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-actions): autodetect GitHub Actions registry urls for Enterprise Server #23042

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Jun 29, 2023

Changes

This PR enhances the detection of GitHub Actions registry URLs for Enterprise Server instances. It automatically determines the GitHub URL from the endpoint and prepends it to the registryUrls when searching for GitHub Actions. This allows Renovate to search for a GitHub Action on the GitHub Enterprise Server first, and then on github.com, mirroring the same behavior as GitHub's native Action consumption.

Context

Requires #23041 to take affect, but technically won't break without it merged

Fixes #10178

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Shegox Shegox requested a review from rarkins June 30, 2023 06:37
@Shegox Shegox requested a review from viceice July 7, 2023 10:39
viceice
viceice previously approved these changes Jul 17, 2023
@Xplouder
Copy link

Xplouder commented Aug 8, 2023

@rarkins any chance to have this merged? thank you

@rarkins rarkins added this pull request to the merge queue Aug 8, 2023
Merged via the queue into renovatebot:main with commit 853f028 Aug 8, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHE: github-actions should lookup new versions from current host/endpoint
5 participants