feat: Utility class for Result values
#23059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jun 30, 2023
viceice
previously approved these changes
Jun 30, 2023
auto-merge was automatically disabled
June 30, 2023 13:35
Head branch was pushed to by a user without write access
zharinov
changed the title
Result<T, E> valuesResult values
rarkins
approved these changes
Jun 30, 2023
|
🎉 This PR is included in version 35.148.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
viceice
reviewed
Jun 30, 2023
Comment on lines
+1
to
+11
| interface Ok<T> { | ||
| ok: true; | ||
| value: T; | ||
| } | ||
|
|
||
| interface Err { | ||
| ok: false; | ||
| error: Error; | ||
| } | ||
|
|
||
| type Res<T> = Ok<T> | Err; |
There was a problem hiding this comment.
@zharinov can you please export these types in a new PR, as they are used on public API of Result class.
There was a problem hiding this comment.
What can go wrong if we don't do this? I'm quite certain these types are kind of private and I designed Result class to be the only API available here, but what downsides are?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: