Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/npm): add support for Volta's pnpm #23069

Merged
merged 4 commits into from Jun 30, 2023
Merged

feat(manager/npm): add support for Volta's pnpm #23069

merged 4 commits into from Jun 30, 2023

Conversation

oscard0m
Copy link
Contributor

@oscard0m oscard0m commented Jun 30, 2023 •
edited

Changes

  • feat(manager/npm): add support for Volta's pnpm
  • docs(manager/npm): update description of supported volta engines
  • test(manager/npm): update test coverage for volta's pnpm
  • test(manager/npm): add test coverage for 'unknown-volta'

Context

Resolves #23068

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@oscard0m oscard0m changed the title feature/volta pnpm support feat(manager/npm): add support for Volta's pnpm Jun 30, 2023
@oscard0m oscard0m marked this pull request as draft June 30, 2023 17:18
viceice
viceice reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/npm/extract/index.ts Show resolved Hide resolved
@oscard0m oscard0m marked this pull request as ready for review June 30, 2023 17:45
@oscard0m oscard0m requested a review from viceice June 30, 2023 17:52
@rarkins rarkins added this pull request to the merge queue Jun 30, 2023
Merged via the queue into renovatebot:main with commit 558535e Jun 30, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.150.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscard0m oscard0m deleted the feature/volta-pnpm-support branch June 30, 2023 19:57
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscard0m @renovate-release @viceice @rarkins