fix(nuget): Sort api response before picking projectUrl #23090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epage Use the existing NuGet versioning module to sort versions Add test including anonymised actual response from Azure DevOps package feed for nunit
viceice
requested changes
Jul 3, 2023
|
I think this is about as terse as I can get them without breaking anything. edit: actually I could also remove some intermediate versions of nunit from the registration API response. |
viceice
requested changes
Jul 17, 2023
viceice
reviewed
Aug 8, 2023
lib/modules/datasource/nuget/__fixtures__/azure_devops/nunit/nuspec.xml
Outdated
Show resolved
Hide resolved
viceice
reviewed
Sep 6, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Oct 15, 2023
|
🎉 This PR is included in version 37.20.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jon4hz
pushed a commit
to jon4hz/renovate
that referenced
this pull request
Nov 9, 2023
…23090) Co-authored-by: Rhys Arkins <rhys@arkins.net> Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sort NuGet API responses using the versioning module before finding the latest projectUrl
Add test including response from Azure DevOps package feed for nunit
Context
Closes #22887
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: