Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: allow post upgrade templating by default #23126

Merged
merged 1 commit into from Jul 4, 2023
Merged

feat!: allow post upgrade templating by default #23126

merged 1 commit into from Jul 4, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 4, 2023

Changes

Defaults fileFilters to everything

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
feat!: default fileFilters to everything
99a03e5 
BREAKING CHANGE: postUpgradeTasks will now default to committing everything
@rarkins rarkins requested a review from viceice July 4, 2023 09:35
@rarkins rarkins changed the title feat!: allow post upgrade templating by default (#21326) feat!: allow post upgrade templating by default Jul 4, 2023
@viceice viceice added the breaking Breaking change, requires major version bump label Jul 4, 2023
@rarkins rarkins merged commit 9014b8d into v36 Jul 4, 2023
34 checks passed
@rarkins rarkins deleted the feat/default-file-filters branch July 4, 2023 13:51
rarkins added a commit that referenced this pull request Jul 4, 2023
@rarkins
feat!: allow post upgrade templating by default (#23126)
e28fee5
rarkins added a commit that referenced this pull request Jul 4, 2023
@rarkins
feat!: commit all files in postUpgradeTasks by default (#23126)
6d93c2d 
BREAKING CHANGE: all modified files are now commited by default for postUpgradeTasks.fileFilters
rarkins added a commit that referenced this pull request Jul 4, 2023
@rarkins
feat!: commit all files in postUpgradeTasks by default (#23126)
ca06f6d 
BREAKING CHANGE: all modified files are now commited by default for postUpgradeTasks.fileFilters
rarkins added a commit that referenced this pull request Jul 4, 2023
@rarkins
feat!: commit all files in postUpgradeTasks by default (#23126)
9845082 
BREAKING CHANGE: all modified files are now commited by default for postUpgradeTasks.fileFilters
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rarkins @viceice