Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle-wrapper): Show release notes in PR #23133

Merged
merged 4 commits into from Jul 7, 2023
Merged

fix(gradle-wrapper): Show release notes in PR #23133

merged 4 commits into from Jul 7, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 4, 2023

Changes

  • Add gitRef field which is necessary for release notes fetching

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

zharinov commented Jul 4, 2023

Example: renovate-testing/test-23097-gradle-changelog#2

@zharinov zharinov requested a review from rarkins July 4, 2023 14:54
rarkins
rarkins reviewed Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's defer until after v36

viceice
viceice requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer

@rarkins rarkins requested a review from viceice July 5, 2023 11:07
@rarkins rarkins enabled auto-merge July 5, 2023 11:07
@zharinov zharinov requested review from viceice and removed request for viceice July 6, 2023 15:03
@rarkins rarkins disabled auto-merge July 7, 2023 07:07
@rarkins rarkins merged commit ce7acdd into renovatebot:main Jul 7, 2023
36 checks passed
@rarkins rarkins deleted the fix/gradle-version-changelog branch July 7, 2023 08:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @renovate-release @viceice @rarkins