Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(changelog/gitlab): custom endpoint and repository length validation #23165

Merged
merged 5 commits into from Jul 5, 2023
Merged

fix(changelog/gitlab): custom endpoint and repository length validation #23165

merged 5 commits into from Jul 5, 2023

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Jul 5, 2023 •
edited

Changes

Fixes GitLab repository length validation and custom registry support

Context

#23156

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy added type:bug Bug fix of existing functionality core:changelogs Related to changelogs/release notes fetching labels Jul 5, 2023
viceice
viceice reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/workers/repository/update/pr/changelog/gitlab/source.ts Show resolved Hide resolved
@setchy setchy changed the title fix(changelog/gitlab): update repository length validation fix(changelog): custom endpoint and repository length validation Jul 5, 2023
@setchy setchy changed the title fix(changelog): custom endpoint and repository length validation fix(changelog/gitlab): custom endpoint and repository length validation Jul 5, 2023
@setchy setchy requested review from viceice and rarkins July 5, 2023 11:14
@rarkins rarkins enabled auto-merge July 5, 2023 11:22
@rarkins rarkins added this pull request to the merge queue Jul 5, 2023
Merged via the queue into renovatebot:main with commit dbe5f09 Jul 5, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

setchy added a commit to setchy/renovate that referenced this pull request Jul 5, 2023
@setchy
fix(changelog/gitlab): custom endpoint and repository length validati…
478f552 
…on (renovatebot#23165)
@setchy setchy mentioned this pull request Jul 5, 2023
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@HonkingGoose HonkingGoose HonkingGoose left review comments

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
core:changelogs Related to changelogs/release notes fetching type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@setchy @renovate-release @viceice @rarkins @HonkingGoose