Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): automatic update of static data #23263

Merged
merged 7 commits into from Jul 10, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 9, 2023

Automated changes by create-pull-request GitHub action

viceice
viceice previously approved these changes Jul 9, 2023
@viceice viceice enabled auto-merge July 9, 2023 10:13
@viceice viceice disabled auto-merge July 9, 2023 10:14
@viceice
Copy link
Member

viceice commented Jul 9, 2023

@rarkins can you please admin merge?

@rarkins
Copy link
Collaborator

rarkins commented Jul 10, 2023

@viceice @JamieMagee I'm seeing this failure which may be related to the data? https://github.com/renovatebot/renovate/actions/runs/5499322484/jobs/10021472772

@rarkins
Copy link
Collaborator

rarkins commented Jul 10, 2023

I've pushed a commit which fixes the tests for bookworm, and then a second commit which I think is correct but breaks them again. In short, bookworm and 12 are showing up as not stable - which I think is a data error. @Gabriel-Ladzaretti can you take a look?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins we should fake date inside tests, so it never break on existing tests because of time forward. we already don't for node.

@Gabriel-Ladzaretti
Copy link
Collaborator

Gabriel-Ladzaretti commented Jul 10, 2023

const dt = DateTime.fromISO('2022-04-20');

The tests are fixed in time, therefore bookworm wasnt released yet.
Did you try changing the date?

@rarkins
Copy link
Collaborator

rarkins commented Jul 10, 2023

Changing the date fixes some, but not all. It still says 12/bookworm isn't stable. @Gabriel-Ladzaretti can you dive into this PR when you get the time?

@Gabriel-Ladzaretti
Copy link
Collaborator

Gabriel-Ladzaretti commented Jul 10, 2023

The fixed year should probably be 2023. stretch eol_lts": "2022-06-30", therefore above seems correct

@rarkins rarkins requested a review from viceice July 10, 2023 07:14
@rarkins rarkins added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 3fced20 Jul 10, 2023
36 checks passed
@rarkins rarkins deleted the chore/update-static-data branch July 10, 2023 07:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants