fix: compute recreateClosed
for normal PRs
#23298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Ref: #23282
The above issue arises because we use
recreateClosed
to decide whether to check a PR already exists or not here. But therecreateClosed
value is only calculated for immortal PRs and not normal PR.Hence, for normal PRs that have been closed previously coouldn't be recreated.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: