Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compute recreateClosed for normal PRs #23298

Merged
merged 1 commit into from Jul 11, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jul 11, 2023

Changes

Context

Ref: #23282
The above issue arises because we use recreateClosed to decide whether to check a PR already exists or not here. But the recreateClosed value is only calculated for immortal PRs and not normal PR.

Hence, for normal PRs that have been closed previously coouldn't be recreated.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh
Copy link
Collaborator Author

Test-run:
Config allows only xmldoc to be recreated.
Xmldoc : closed Pr recreated Pr
Node : closed Pr { no open Pr, as it follows default behaviour }

@rarkins rarkins added this pull request to the merge queue Jul 11, 2023
Merged via the queue into renovatebot:main with commit 9666506 Jul 11, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants