Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rubygems): Restrict metadata cache to rubygems.org host #23307

Merged
merged 1 commit into from Jul 11, 2023
Merged

fix(rubygems): Restrict metadata cache to rubygems.org host #23307

merged 1 commit into from Jul 11, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 11, 2023 •
edited

Changes

We don't want cache private registry URLs.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins July 11, 2023 18:51
viceice
viceice reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a description to the PR why we do this change? otherwise some time in future someone will ask why .

@rarkins rarkins added this pull request to the merge queue Jul 11, 2023
Merged via the queue into renovatebot:main with commit 0bc7e61 Jul 11, 2023
36 checks passed
@rarkins rarkins deleted the fix/rubygems-metadata-cache-rubygems-only branch July 11, 2023 19:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice left review comments

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @renovate-release @viceice @rarkins