New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datasource): re-encode URL to support white spaces in Azure projects #23354
Merged
JamieMagee
merged 8 commits into
renovatebot:main
from
leuchterag:fix/support-whitespaces
Jul 19, 2023
Merged
fix(datasource): re-encode URL to support white spaces in Azure projects #23354
JamieMagee
merged 8 commits into
renovatebot:main
from
leuchterag:fix/support-whitespaces
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
reviewed
Jul 13, 2023
JamieMagee
approved these changes
Jul 14, 2023
viceice
approved these changes
Jul 17, 2023
please stop merging main, GitHub merge queue will do it for you |
@JamieMagee @viceice Hi, is there anything else to do to have this merged? |
🎉 This PR is included in version 36.13.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The URL for GIT submodules are decoded as a side-effect of the
git-url-parse
node module. This leads to errors when using submodules with whitespaces in the URL, e.g. Azure DevOps project name.Error:
"WARN: Error mapping git submodules during extraction"
, raised inextract.ts
and originating fromindex.js
ingit-url-parse
.Context
The
gitUrlParse
function respects the fact that in some hosting services such as Azure DevOps, you can use white-space characters in the repository and owner names. It URI-decodes the components accordingly and uses these to assemble the full_name property. This is done independently of the hosting environment.When the
GitUrl
object is later used to compose the repository string, however, these components are not re-encoded. The full_name property is used to build the string.I already tried to fix the issue in the affected submodule (active PR here), but the owner does not seem to maintain the repository anymore.
Hence, I attempted a fix in your module.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: