Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datasource/conan): continue on error during fetching package url #23391

Merged
merged 6 commits into from Jul 21, 2023
Merged

fix(datasource/conan): continue on error during fetching package url #23391

merged 6 commits into from Jul 21, 2023

Conversation

MartijnLeijssen-TomTom
Copy link
Contributor

@MartijnLeijssen-TomTom MartijnLeijssen-TomTom commented Jul 15, 2023 •
edited by viceice

Changes

Ignore errors during fetching package url of a conan package when using jfrog artifactory

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MartijnLeijssen-TomTom MartijnLeijssen-TomTom changed the title Fix(conan): continue on error during fetching conan package url fix(conan): continue on error during fetching conan package url Jul 15, 2023
@MartijnLeijssen-TomTom MartijnLeijssen-TomTom mentioned this pull request Jul 15, 2023
Closed
viceice
viceice previously approved these changes Jul 17, 2023
View reviewed changes
HonkingGoose
HonkingGoose suggested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR will now close the correct issue.

Maybe one small style fix and we're good to go, from my end, at least.

lib/modules/datasource/conan/index.ts Outdated Show resolved Hide resolved
HonkingGoose
HonkingGoose approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. I'll let the maintainers review it further.

@MartijnLeijssen-TomTom
Copy link
Contributor Author

From my point of view this change can be merged

@viceice viceice changed the title fix(conan): continue on error during fetching conan package url fix(datasource/conan): continue on error during fetching package url Jul 21, 2023
@viceice viceice added this pull request to the merge queue Jul 21, 2023
Merged via the queue into renovatebot:main with commit bca8175 Jul 21, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.18.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

zharinov pushed a commit to zharinov/renovate that referenced this pull request Jul 22, 2023
@MartijnLeijssen-TomTom @zharinov
fix(datasource/conan): continue on error during fetching package url (r…
ee2e5d0 
…enovatebot#23391)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate fails to update conan packages without conan.package.url property
4 participants
@MartijnLeijssen-TomTom @renovate-release @viceice @HonkingGoose