chore: fix devcontainer on codespaces #23412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I tried a lot of things, but I still could not figure out what's going on and why this issue only happens with Codespaces. |
felipecrs
force-pushed
the
fix-devcontainer
branch
2 times, most recently
from
3da5103
to
5a33cc4
Compare
So that the Codespaces workaround will only be applied on Codespaces. And also reorganize devcontainer.json.
felipecrs
force-pushed
the
fix-devcontainer
branch
from
5a33cc4
to
a003b62
Compare
viceice
reviewed
Jul 17, 2023
felipecrs
added a commit
to felipecrs/renovatebot.github.io
that referenced
this pull request
Jul 17, 2023
This PR takes the improvements from renovatebot/renovate#23378 and renovatebot/renovate#23412 and applies them to this devcontainer, among other improvements which are specific to this project.
JamieMagee
previously approved these changes
Jul 17, 2023
|
@JamieMagee sorry I had just forgot a small cosmetic change. |
viceice
approved these changes
Jul 17, 2023
|
🎉 This PR is included in version 36.9.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the permissions of /tmp, which for some reason is broken on GitHub Codespaces (but not locally) when the container is created.
1777 is the proper permissions set for /tmp: https://unix.stackexchange.com/a/71625/427940
I still don't know the root cause, and I'll try to investigate.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: