Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git-submodule): remove token injection from submodule URL #23458

Merged
merged 4 commits into from Jul 21, 2023
Merged

fix(git-submodule): remove token injection from submodule URL #23458

merged 4 commits into from Jul 21, 2023

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Jul 19, 2023 •
edited

Changes

This PR removes the token injection from the submodule URL. This was previously required to authenticate against Git hosts to retrieve the default branch. As of #22061 this logic is no longer needed as the authentication is injected via Git Environment variables and can even cause problems as it alters the format of the submodule url to something like https://token@github.com/org/repo and this won't be working with the git insteadOf syntax.

Context

Follow up to #22061

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Shegox Shegox requested a review from JamieMagee as a code owner July 19, 2023 16:44
@Shegox Shegox marked this pull request as draft July 19, 2023 16:54
@Shegox Shegox marked this pull request as ready for review July 19, 2023 17:07
viceice
viceice reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a fix pr

@Shegox Shegox changed the title refactor(git-submodule): remove token injection from submodule URL fix(git-submodule): remove token injection from submodule URL Jul 19, 2023
@Shegox Shegox requested a review from viceice July 21, 2023 11:29
@JamieMagee JamieMagee added this pull request to the merge queue Jul 21, 2023
Merged via the queue into renovatebot:main with commit 807b796 Jul 21, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.18.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

zharinov pushed a commit to zharinov/renovate that referenced this pull request Jul 22, 2023
@Shegox @zharinov
fix(git-submodule): remove token injection from submodule URL (renova…
c95a97d 
…tebot#23458)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shegox @renovate-release @JamieMagee @viceice