Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rubygems): Simplify tests #23521

Merged
merged 23 commits into from Jul 23, 2023
Merged

test(rubygems): Simplify tests #23521

merged 23 commits into from Jul 23, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 23, 2023 •
edited

Changes

  • Remove snapshots
  • Don't use thirdparty.com and firstparty.com which are confusing as hell
  • Remove couple duplicate tests
  • Use library for dumping data into Ruby marshal format, instead of using hard-coded buffers

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
refactor(rubygems): Extract v1 API handling
18d50e6
@zharinov
feat: Add assignKeys utility function
01d07fd
@zharinov
Fix
7c66dfa
@zharinov
Merge branch 'main' into refactor/rubygems-extract-v1-fetch
af7551f
@zharinov
Merge branch 'main' into refactor/rubygems-extract-v1-fetch
ebf0b49
@zharinov
fix: Better types for assignKeys utility (renovatebot#23496)
3a30944
@zharinov
refactor: Make AsyncResult a PromiseLike
18d0bfb
@zharinov
Unified signature for transform
c933452
@zharinov
feat: Support .catch method for Result
08e4fa2
@zharinov
Refactor
665a4aa
@zharinov
Fix
e135d0f
@zharinov
Merge branch 'main' into refactor/rubygems-extract-v1-fetch
dab947c
@zharinov
Merge branch 'main' of github.com:renovatebot/renovate into refactor/…
2289ec2 
…rubygems-extract-v1-fetch
@zharinov
Merge branch 'main' into refactor/rubygems-extract-v1-fetch
6a1469b
@zharinov
Merge branch 'main' into refactor/rubygems-extract-v1-fetch
bcb7667
@zharinov
Refactor
de79cb9
@zharinov
Merge branch 'main' into refactor/rubygems-extract-v1-fetch
2f81add
@zharinov
refactor(rubygems): Unify fetching via v1 API
21db221
@zharinov
Merge branch 'main' into refactor/unify-v1-fetching
ef6195a
@zharinov
Merge branch 'main' of github.com:renovatebot/renovate into refactor/…
ce1238b 
…unify-v1-fetching
@zharinov
Merge branch 'refactor/unify-v1-fetching' of github.com:zharinov/reno…
6752773 
…vate into refactor/unify-v1-fetching
@zharinov
test(rubygems): Simplify tests
7104dd5
@zharinov
Merge branch 'main' of github.com:renovatebot/renovate into refactor/…
8e4371d 
…rubygems-test

# Conflicts:
#	lib/modules/datasource/rubygems/index.spec.ts
@zharinov zharinov requested a review from viceice July 23, 2023 13:31
zharinov
zharinov commented Jul 23, 2023
View reviewed changes
package.json Show resolved Hide resolved
@viceice viceice added this pull request to the merge queue Jul 23, 2023
Merged via the queue into renovatebot:main with commit 285bed3 Jul 23, 2023
36 checks passed
@viceice viceice deleted the refactor/rubygems-test branch July 23, 2023 14:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zharinov @renovate-release @viceice