Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rubygems): Use cascade of endpoints for unknown servers #23523

Merged
merged 10 commits into from Jul 25, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 23, 2023

Changes

For registries other than rubygems.org, rubygems.pkg.github.com or gitlab.com, following endpoints are queried:

  • First request: /api/v1/versions/{package}.json
    • It's useful because it contains date for releaseTimestamp field
    • Optionally, metadata such as homepageUrl will be queried via /api/v1/gems/{package}.json
  • Fallback 1: /info/{package} endpoint (example)
  • Fallback 2: /api/v1/dependencies (obsolete but still working)

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

@zharinov zharinov marked this pull request as ready for review July 25, 2023 12:25
@zharinov zharinov requested a review from viceice July 25, 2023 12:25
@zharinov zharinov marked this pull request as draft July 25, 2023 12:52
@zharinov zharinov changed the title fix(rubygems): Try different fallback requests fix(rubygems): Use cascade of endpoints for unknown servers Jul 25, 2023
@zharinov zharinov marked this pull request as ready for review July 25, 2023 14:07
@zharinov zharinov requested a review from viceice July 25, 2023 14:41
@zharinov
Copy link
Collaborator Author

Sorry, made changes at the last moment. PR description is updated accordingly.

@viceice viceice added this pull request to the merge queue Jul 25, 2023
Merged via the queue into renovatebot:main with commit 992b336 Jul 25, 2023
34 checks passed
@viceice viceice deleted the fix/rubygems-fallback-requests branch July 25, 2023 15:51
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Nexus repository manager for RubyGems
4 participants