Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Renovate's status check strings #23530

Closed
rarkins opened this issue Jul 24, 2023 Discussed in #23141 · 6 comments · Fixed by #26047
Closed

Customize Renovate's status check strings #23530

rarkins opened this issue Jul 24, 2023 Discussed in #23141 · 6 comments · Fixed by #26047
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jul 24, 2023

Discussed in #23141

Originally posted by HonkingGoose April 17, 2023

What would you like Renovate to be able to do?

I would like to think if it's the right time to let users customize Renovate's status check strings too

Originally posted by @rarkins in #21376 (comment)

If you have any ideas on how this should be implemented, please tell us here.

I'll let the maintainers figure out the requirements and implementation details. 😉

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started labels Jul 24, 2023
@rarkins rarkins added status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 1, 2023
@rarkins
Copy link
Collaborator Author

rarkins commented Oct 17, 2023

Proposal: new option statusCheckNames with default values:

{
  "minimumReleaseAge": "renovate/stability-days",
  "mergeConfidence": "renovate/merge-confidence"
}

@rarkins
Copy link
Collaborator Author

rarkins commented Oct 17, 2023

  • We should validate the object to make sure it's string->string and that the keys can only be the two above.
  • Setting to null or empty string would mean it's disabled/skipped

@RahulGautamSingh
Copy link
Collaborator

Should we also add the status check strings for artifacts ie. renovate/artifacts and the config validation status check we use for reconfigure branch renovate/config-validation to the list?

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 27, 2023

Yes

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Nov 27, 2023

Do we want the field to be mergeable?
ie.
// user config

statusCheckNames: {
  "minimumReleaseAge": "some-string"
}

Then should the other values ie. nergeConfidence use the default value or should they be undefined.

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 27, 2023

Yes, mergeable so that you only need to specify the values you want to override

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants