Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use minimatch util #23549

Merged
merged 4 commits into from Jul 26, 2023

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Jul 24, 2023

Changes

refactor minimatch match use-cases to use cacheable util

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy requested a review from viceice July 24, 2023 20:56
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you measure any performance improvement?

lib/modules/manager/npm/extract/utils.ts Outdated Show resolved Hide resolved
@setchy
Copy link
Collaborator Author

setchy commented Jul 25, 2023

can you measure any performance improvement?

I haven't (and didn't intend to) spend time on measuring any performance gains (if at all)

@secustor secustor added this pull request to the merge queue Jul 26, 2023
Merged via the queue into renovatebot:main with commit 2159444 Jul 26, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy deleted the refactor/update-minimatch-usecases branch July 26, 2023 20:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants