Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reuse datasource filtering #23716

Merged
merged 5 commits into from Aug 7, 2023
Merged

refactor: Reuse datasource filtering #23716

merged 5 commits into from Aug 7, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Aug 4, 2023 •
edited

Changes

  • Change order of parameters
  • Combine 4 filtering functions into one
  • Some other adjustments

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice August 4, 2023 18:06
@zharinov zharinov requested a review from viceice August 5, 2023 19:11
@viceice viceice added this pull request to the merge queue Aug 7, 2023
Merged via the queue into renovatebot:main with commit 17bf7d7 Aug 7, 2023
36 checks passed
@viceice viceice deleted the refactor/reuse-datasource-filter-fns branch August 7, 2023 20:14
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zharinov @renovate-release @viceice